Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version qualifier fixes #3124

Merged
merged 3 commits into from
Jan 17, 2025
Merged

version qualifier fixes #3124

merged 3 commits into from
Jan 17, 2025

Conversation

seanstory
Copy link
Member

Part of https://github.com/elastic/search-team/issues/9111

Turns out that when you source somescript.sh instead of ./somescript.sh, overrides of exported variables propagate up, instead of staying local to their assignment. So https://github.com/elastic/connectors/pull/3123/files ended up overwriting VERSION_QUALIFIER for both snapshot AND staging workflows. 🤦

This instead swithces publish-daily-release-artifact.sh to use it's own local variable of version_qualifier, rather than overwriting the provided value of VERSION_QUALIFIER.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

@seanstory seanstory requested a review from a team as a code owner January 17, 2025 20:31
kderusso
kderusso approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubberstamp:

@seanstory seanstory merged commit f44a3e1 into main Jan 17, 2025
4 checks passed
@seanstory seanstory deleted the seanstory/version-qualifier-fixes branch January 17, 2025 20:42
@github-actions GitHub Actions
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3124 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderusso kderusso kderusso approved these changes

Assignees
No one assigned
Labels
auto-backport v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanstory @kderusso